Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix existing state tests #270

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

TahaTesser
Copy link
Collaborator

@TahaTesser TahaTesser commented Jul 22, 2024

This PR fixes existing broken tests

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors.
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • The package compiles with the minimum Flutter version stated in the pubspec.yaml

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@TahaTesser
Copy link
Collaborator Author

This fixes the existing tests, all checks are green now. Please moving forward if a PR breaks existing tests we should let the author update the PR to fix those tests and only merge PR on green checks.

@TahaTesser TahaTesser requested a review from ulusoyca July 22, 2024 20:51
Copy link
Collaborator

@ulusoyca ulusoyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are the best!

@TahaTesser TahaTesser merged commit 0f4c556 into woltapp:main Jul 23, 2024
3 checks passed
@TahaTesser TahaTesser deleted the fix_state_tests branch July 23, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants