Fix: Consider directionality for pagination animation #272
Conversation
ulusoyca
changed the title
| Animation<Offset> mainContentSlidePosition( | ||
| AnimationController controller, | ||
| WoltModalSheetPaginationAnimationStyle style, { | ||
| required double sheetWidth, | ||
| required double screenWidth, | ||
| required bool isForwardMove, | ||
| required bool isLTR, // New parameter to determine the text direction |
There was a problem hiding this comment.
| required bool isLTR, // New parameter to determine the text direction | |
| required bool isLTR, // New parameter to determine the text direction |
Instead of this, we could use a textDirection parameter and pass Directionality.of(context)
There was a problem hiding this comment.
Could we make this parameter optional? That way we can always default to LTR when this parameter is null.
There was a problem hiding this comment.
Changed the parameter type: d5fab23
I would avoid making it optional. First of all, this is not public API. Second, the maintainers should always consider the directionality when calling this.
There was a problem hiding this comment.
Second, the maintainers should always consider the directionality when calling this.
I agree, it should be textDirection which is the value of Directionality.of(context) instead a bool parameter for "isLTR'
lib/src/content/components/paginating_group/wolt_modal_sheet_page_transition_state.dart
Outdated
Show resolved
Hide resolved
| Animation<Offset> mainContentSlidePosition( | ||
| AnimationController controller, | ||
| WoltModalSheetPaginationAnimationStyle style, { | ||
| required double sheetWidth, | ||
| required double screenWidth, | ||
| required bool isForwardMove, | ||
| required bool isLTR, // New parameter to determine the text direction |
There was a problem hiding this comment.
Could we make this parameter optional? That way we can always default to LTR when this parameter is null.
ulusoyca
force-pushed
the
fix-rtl-for-slide-animation
branch
from
157a0bc
to
d5fab23
Compare
Summary
ThisPR introduces support for both Left-to-Right (LTR) and Right-to-Left (RTL) text directions in the slide animation logic for modal sheet page transitions. The mainContentSlidePosition method is updated to handle different slide directions based on a new
isLTRparameter.Changes
Calculated directionMultiplier based on
isLTRandisForwardMoveto correctly adjust the animation direction.For LTR (isLTR = true), the multiplier is 1 for forward moves and -1 for backward moves.
For RTL (isLTR = false), the multiplier is -1 for forward moves and 1 for backward moves.
before_ltr.mov
after_ltr.mov
before_rtl.mov
after_rtl.mov
Related Issues
Fixes #266
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process.
///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
after_rtl.mov