Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing types #332

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add missing types #332

wants to merge 1 commit into from

Conversation

ueman
Copy link

@ueman ueman commented Oct 2, 2024

Description

This place was missing the types, so you could actually run into an issue where you pass incompatible types.

You could actually test this by enabling the strong language analyzer options:

analyzer:
  language:
    strict-raw-types: true
    strict-inference: true
    strict-casts: true

But I don't know whether that's something you want to do. I've briefly tried to enable them, and it shows a lot more issues. That's also why I didn't enable them as a test for these changes.

Related Issues

none

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors.
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • The package compiles with the minimum Flutter version stated in the pubspec.yaml

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

While technically this is a breaking API change (you could pass an unrelated type), it's not a change in behavior (only passing correct types would make the code work)

Copy link
Collaborator

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ulusoyca
Copy link
Collaborator

ulusoyca commented Oct 3, 2024

👑

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants