Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PropTypes with prop-types package #22

Merged
merged 1 commit into from
Jul 11, 2017
Merged

Replace PropTypes with prop-types package #22

merged 1 commit into from
Jul 11, 2017

Conversation

iRoachie
Copy link
Contributor

PropTypes was removed react in v15.5 and moved into it's own package. https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html#migrating-from-react.proptypes

This PR implements that change so the warning no longer shows while developing.

If you're wondering, the package-lock is a new standard which released in npm5 which makes installs much faster.

Also formatted the code a bit :P

@wonday wonday merged commit 1bb7fd1 into wonday:master Jul 11, 2017
@wonday
Copy link
Owner

wonday commented Jul 11, 2017

Thank you, :-)

@iRoachie iRoachie deleted the prop-types branch July 11, 2017 16:06
@iRoachie
Copy link
Contributor Author

Anytime! :)

@viperfx viperfx mentioned this pull request Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants