Fix: Compatibility with Windows Paths #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution! A test covering this would be good, but I am aware that is not possible in CI and blocked by #71 at the moment. |
|
Thank you for your prompt response and guidance. I'm eager to contribute a test for this fix. Could you please provide some insights on how to write the test and the necessary tools I should prepare for the task? Your advice would be greatly appreciated. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a compatibility issue with Windows paths in PHP_CodeSniffer. When the system uses backslashes (e.g.,
\\) as directory separators on Windows, it can lead to problems in pattern matching withpreg_match.To fix this issue, we have added a conditional check to ensure that Windows paths are consistently using forward slashes (e.g.,
/) as directory separators before adding them to the ignore patterns. This change ensures that paths are correctly matched and ignored, even on Windows systems.This should resolve the "Compilation failed" warning related to
preg_matchthat you've encountered.Please review this pull request and let us know if it solves your problem. If you have any further comments or suggestions, feel free to share them. Thank you!