Upgrade the workflows in GitHub Actions to use Node.js v20 #2404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eason9487
force-pushed
the
dev/2218-upgrade-gha-workflows
branch
from
b563281 to
e92dba1
Compare
eason9487
force-pushed
the
dev/2218-upgrade-gha-workflows
branch
from
28893a4 to
fd703d8
Compare
…ork." This reverts commit 4b4abe1.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2404 +/- ##
===========================================
- Coverage 64.5% 64.1% -0.4%
Complexity 4252 4252
===========================================
Files 458 755 +297
Lines 18041 21528 +3487
Branches 0 1157 +1157
===========================================
+ Hits 11634 13797 +2163
- Misses 6407 7570 +1163
- Partials 0 161 +161
Flags with carried forward coverage won't be shown. Click here to find out more. |
puntope
reviewed
May 17, 2024
There was a problem hiding this comment.
Thanks @eason9487 the only thing I miss here is the branch label assignation as mentioned in
https://github.com/woocommerce/automatewoo-birthdays/pull/139#issuecomment-2116662381
|
Hi @puntope, thanks for the review.
Please refer to https://github.com/woocommerce/automatewoo-birthdays/pull/139#issuecomment-2116918286 |
puntope
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes #2218
This PR upgrades the workflows in GitHub Actions to use Node.js v20.
Detailed test instructions:
Changelog entry