Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the root dependencies and setup to use Node.js v20 #113

Merged
merged 4 commits into from
Apr 25, 2024

Conversation

eason9487
Copy link
Member

Changes proposed in this Pull Request:

Part of #108

This PR:

  • Bump dependencies and regenerate package-lock.json for this repo with Node.js v20.
  • Set minimum support for Node.js to ">=18", which align with the dependencies' minimum (@wordpress/scripts@27.7.0).
  • Set .nvmrc to use Node.js v20.
  • Fix eslint errors for the samples files.
  • Update the "Publish Compat Checker package" workflow to use Node.js v20.

💡 These workflows depend on the release version, woocommerce/grow/<action_name>@actions-v1, so they will be upgraded after the @actions-v2 is published.

  • .github/workflows/js-linting.yml
  • .github/workflows/php-coding-standards.yml
  • .github/workflows/run-qit-all.yml

Detailed test instructions:

  1. JS linter
    • Use Node.js v20
    • npm install
    • npm run lint:js to see if the linter can be run and if the linting can pass
      • There may be some import/no-unresolved warnings. This kind of warnings can be ignore because the packages of sub-packages may not be installed.
    • Repeat this test with Node.js v18
  2. Inspect the "Publish Compat Checker package" workflow

@eason9487 eason9487 requested a review from a team April 23, 2024 11:04
@eason9487 eason9487 self-assigned this Apr 23, 2024
@eason9487
Copy link
Member Author

I will be skipping the code review process as it can be optional for a devs-facing only change.

@eason9487 eason9487 merged commit ae77eac into update/108-nodejs-v20 Apr 25, 2024
1 check passed
@eason9487 eason9487 deleted the update/108-nodejs-v20-root-deps branch April 25, 2024 02:58
@eason9487 eason9487 mentioned this pull request Apr 25, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant