-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retrying Commerce Integration Creation on Falure. #1078
Merged
message-dimke
merged 8 commits into
update/revise-integration-data-usage
from
add/create-commerce-integration-retry
Oct 23, 2024
Merged
Retrying Commerce Integration Creation on Falure. #1078
message-dimke
merged 8 commits into
update/revise-integration-data-usage
from
add/create-commerce-integration-retry
Oct 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ep where they belong; - Introducing Commerce Integration controller class; - Adjusting unit tests; - Adding commerce integration retry action registration; - Adding commerce integration retry actions cleanup on disconnect;
… create the integration if the one is missing.
budzanowski
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
…be changed in the future without paying attention to set a proper time frame for it.
…ration-sync Synchronising Commerce Integration `partner_metadata` weekly.
7866462
into
update/revise-integration-data-usage
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog: add
A new feature, function, or functionality was added.
type: enhancement
The issue is a request for an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR introduces the initial create Commerce Integration call retry procedure. It may happen that the Create Integration API will fail. We have to retry its creation since the integration data is crucial for assigning customers to a proper Pinterest advertisement platform on the Pinterest side.
The code will try three times: in a minute after the initial failure; in an hour; in a day.
Detailed test instructions:
APIV5::create_commerce_integration
call fail.pinterest-for-woocommerce/src/API/APIV5.php
Lines 407 to 413 in f48b082
It should also have an
attempt
number parameter set to1
, meaning this is the first attempt of a retry.pinterest-for-woocommerce
log for a message about the failure and the retry procedure.Changelog entry