Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Jquery Pointer Events Polyfill (PEP) #1654

Merged
merged 1 commit into from
May 5, 2021
Merged

Remove Jquery Pointer Events Polyfill (PEP) #1654

merged 1 commit into from
May 5, 2021

Conversation

Ismail-elkorchi
Copy link
Contributor

@Ismail-elkorchi Ismail-elkorchi commented Apr 21, 2021

By the time Jquery Pointer Events Polyfill was introduced (#982) the Pointer events API was not supported in all major browsers. This is not the case today, as the Pointer events API is now supported in the majority of current browsers, which makes this polyfill unnecessary.

PEP development ceased in 2018. A few minor maintenance patches have been pushed since then, and the latest version (0.5.3) has been published to npm. However, native support for Pointer Events is relatively good in most browsers at this point - see caniuse: Pointer Events. This project is now archived.

Source : https://github.com/jquery-archive/PEP#project-status

However, while PEP may now be deprecated, the future of Pointer Events themselves is looking good, with the native API now supported in the majority of current browsers (see caniuse.com/pointer). For this reason, unless a project specifically targets older browser versions, we would strongly encourage developers to stop including PEP and to instead rely solely on native Pointer Events.

source : https://openjsf.org/blog/2021/02/10/pointer-events-polyfill-pep-enters-emeritus-status-at-the-openjs-foundation/

Changelog

Enhancement – Remove Jquery Pointer Events Polyfill (PEP). #1654

@Ismail-elkorchi Ismail-elkorchi requested a review from a team as a code owner April 21, 2021 01:11
@Ismail-elkorchi Ismail-elkorchi requested review from ralucaStan and removed request for a team April 21, 2021 01:11
@ralucaStan ralucaStan removed their request for review April 27, 2021 08:33
@nerrad
Copy link
Contributor

nerrad commented Apr 30, 2021

Thanks for the PR! Before we can consider this can you please add some testing notes around what this change impacts and verify you have tested your PR? Thanks!

@nerrad nerrad added type: enhancement The issue is a request for an enhancement. type: technical debt This issue/PR represents/solves the technical debt of the project. status: needs review PR that needs review labels Apr 30, 2021
@mikejolley
Copy link
Member

mikejolley commented May 5, 2021

We can pull the testing instructions from #982 for this since when testing against current browsers this polyfill should no longer be required. Given the Polyfill is deprecated, I vote we remove it.

Testing Instructions

  • Create a menu with nested items (dropdowns)
  • Using a mouse, you should be able to hover the top item to reveal the menu and click on an item to navigate to a page.
  • Using a touch screen device, when tapping on the top item, the first screen should open the dropdown. Tapping again on the top item should redirect to the page. Note you need to be looking at the site in desktop mode, not handheld. Use a larger device like an iPad or request desktop site in mobile safari.

Copy link
Member

@mikejolley mikejolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested Android and Safari IOS touch events and they function normally.

@mikejolley mikejolley added this to the 3.6.0 milestone May 5, 2021
@mikejolley mikejolley merged commit 4cd0f28 into woocommerce:trunk May 5, 2021
@Ismail-elkorchi Ismail-elkorchi deleted the remove-pep-polyfill branch May 18, 2021 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review PR that needs review type: enhancement The issue is a request for an enhancement. type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants