Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and fix e2e tests #2160

Merged
merged 21 commits into from
Sep 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ module.exports = {
'woocommerce/feature-flag': 'off',
'@wordpress/no-global-active-element': 'warn',
camelcase: 'off',
'@typescript-eslint/no-this-alias': 'off',
},
ignorePatterns: [ '**/*.min.js' ],
};
4 changes: 2 additions & 2 deletions .github/workflows/e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ jobs:
${{ runner.os }}-build-
${{ runner.os }}-

- name: Use Node.js 14.x
- name: Use Node.js 20.x
uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: 20.x

- name: Npm install and build
run: |
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
14.21.1
20.11.1
1 change: 1 addition & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"renovate.json",
"node_modules",
"storefront.zip",
"validate-build.sh",
".*"
]
},
Expand Down
3 changes: 2 additions & 1 deletion e2e/specs/browser.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ describe( 'Storefront', () => {
} );

it( 'should have "built with WooCommerce" footer', async () => {
await expect( page ).toMatch( 'Built with WooCommerce.' );
const footerText = await page.evaluate( () => document.querySelector( 'body' ).innerText );
expect( footerText ).toMatch( 'Built with WooCommerce.' );
} );
} );
Loading
Loading