Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style to coupon error inline message #2178

Conversation

Manussakis
Copy link
Member

This PR fixes the woocommerce/woocommerce#53534 issue caused by merging the woocommerce/woocommerce#48738 PR.

Screenshots

Cart page

Before
image

After
image

Checkout page

Before
image

After
image

How to test the changes in this Pull Request:

  1. Go to both the Cart and Checkout pages.
  2. Add an invalid coupon code.
  3. Verify the error message shows up below the coupon input.
  4. Verify the error message uses the $error color (red) and is left aligned.

Changelog

Fix – Edit, reply and author icons are now displayed in comment list form. #1319

Copy link
Contributor

@imanish003 imanish003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Manussakis, thank you for submitting this PR! I've reviewed the changes and have a clarifying question.

AFAIK This issue only occurs on classic Cart and Checkout pages. Is it correct?

Before your changes:
image

After reviewing your changes, I can confirm:

  • The error message is now properly left-aligned
  • The text color has been updated to use the standard error red
    image

@imanish003 imanish003 added type: bug The issue is a confirmed bug. category: styles Issues related to styling labels Jan 9, 2025
@imanish003 imanish003 merged commit a32d702 into woocommerce:trunk Jan 9, 2025
6 checks passed
@Manussakis
Copy link
Member Author

Hey @imanish003 👋

AFAIK This issue only occurs on classic Cart and Checkout pages. Is it correct?

Yes, that's correct!

@imanish003 imanish003 added this to the 4.6.1 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: styles Issues related to styling type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants