Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Infinite scroll hacks #788

Merged
merged 6 commits into from
Apr 3, 2018
Merged

Remove Infinite scroll hacks #788

merged 6 commits into from
Apr 3, 2018

Conversation

tiagonoronha
Copy link
Contributor

@tiagonoronha tiagonoronha commented Mar 12, 2018 •
edited
Loading

Fixes #781.

@tiagonoronha tiagonoronha added the status: needs review PR that needs review label Mar 12, 2018
@tiagonoronha tiagonoronha changed the title Fix/781 Infinite scroll compatibility with 3.3 and duplicated products issue Mar 12, 2018
@danieldudzic
Copy link
Contributor

@tiagonoronha Thanks for working on this! I'll test it today. 🙏

@danieldudzic
Copy link
Contributor

Did some preliminary testing, but can't confirm 100% that the fix works. I will do more extensive testing tomorrow and let you know.

@danieldudzic
Copy link
Contributor

danieldudzic commented Mar 15, 2018 •
edited
Loading

Posting here for posterity:

I’m still seeing the issue:

screecast

  • I have 23 published products
  • The Shop page displays 12
  • The Customizer displays all 23

@tiagonoronha
Copy link
Contributor Author

@danieldudzic I can't replicate this.

Please setup a test site.

@danieldudzic
Copy link
Contributor

danieldudzic commented Mar 16, 2018 •
edited by tiagonoronha
Loading

@tiagonoronha

http://dev-woocommerce-infinite-scroll.pantheonsite.io/ - running the fix/781 branch of Storefront

< removed login >

@tiagonoronha tiagonoronha added status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. and removed status: needs review PR that needs review labels Mar 19, 2018
@tiagonoronha tiagonoronha added status: needs review PR that needs review and removed status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. labels Mar 21, 2018
@tiagonoronha tiagonoronha changed the title Infinite scroll compatibility with 3.3 and duplicated products issue Remove Infinite scroll hacks Mar 22, 2018
@tiagonoronha
Copy link
Contributor Author

The scope of this PR changed, as changes have been submitted to Jetpack and WooCommerce to enhance compatibility.

Please read:

@tiagonoronha tiagonoronha mentioned this pull request Mar 23, 2018
Merged
mikejolley
mikejolley approved these changes Mar 27, 2018
View reviewed changes
Copy link
Member

@mikejolley mikejolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Just make sure this doesn't ship before the Jetpack/WooCommerce core changes ship. Might want to keep it on hold until then?

@mikejolley mikejolley added status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. and removed status: needs review PR that needs review labels Mar 27, 2018
jeffikus
jeffikus approved these changes Mar 29, 2018
View reviewed changes
Copy link
Contributor

@jeffikus jeffikus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this and works for me with the WC fix branch as well as with the Jetpack master branch.

@tiagonoronha
Copy link
Contributor Author

I'm going to go ahead and merge this PR. By the time 2.3 is released, Jetpack will already be out, as well as the next time version of WooCommerce.

@tiagonoronha tiagonoronha added Status: Approved and removed status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. labels Apr 3, 2018
@tiagonoronha tiagonoronha merged commit b812b8a into master Apr 3, 2018
@tiagonoronha tiagonoronha deleted the fix/781 branch April 3, 2018 11:32
@tiagonoronha tiagonoronha added this to the 2.3.0 milestone Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffikus jeffikus jeffikus approved these changes

@mikejolley mikejolley mikejolley approved these changes

@danieldudzic danieldudzic Awaiting requested review from danieldudzic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tiagonoronha @danieldudzic @mikejolley @jeffikus