This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
Remove use of deprecated @wordpress/date getSettings() #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psealock
previously approved these changes
Dec 10, 2018
There was a problem hiding this comment.
The code looks good for this, and is testing well in the browser.
However, it looks like two tests are failing. Looks like maybe something needs to be defined in the test setup?
TypeError: Cannot read property 'userLocale' of undefined.
Error: No locale meta information provided.
ryelle
previously requested changes
Dec 12, 2018
client/devdocs/example.js
Outdated
| @@ -59,7 +59,7 @@ class Example extends Component { | |||
| ...pkgComponents, | |||
| Component, | |||
| withState, | |||
| getSettings, | |||
| getSettings: __experimentalGetSettings, | |||
There was a problem hiding this comment.
I think you can remove this, since you're not using getSettings in the component anymore.
jeffstieler
force-pushed
the
fix/807-getsettings-deprecated
branch
from
979800e
to
f49c94c
Compare
jeffstieler
changed the title
|
This is happening on console.error node_modules/memize/index.js:74
Jed localization error: Error: No locale meta information provided. |
jeffstieler
dismissed
psealock’s stale review
Several code changes after approval.
|
Thanks @ryelle @justinshreve! This is ready for another review. |
timmyc
approved these changes
Dec 18, 2018
…instead of using experimental retrieval from @wordpress/date.
jeffstieler
force-pushed
the
fix/807-getsettings-deprecated
branch
from
84f135d
to
dcb4a00
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #807.
See: WordPress/gutenberg#10636
Detailed test instructions:
wp.datedeprecation warning is present