Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

Fix react-spring breaking IE11. #2698

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Fix react-spring breaking IE11. #2698

merged 1 commit into from
Jul 24, 2019

Conversation

jeffstieler
Copy link
Contributor

Fixes #2693.

This PR seeks to resolve the react-spring conflict with IE11 by temporarily aliasing the import like in this Gutenberg PR: WordPress/gutenberg#16196.

Once the @wordpress/components package is updated to include the changes in the referenced PR, we can remove the alias.

Detailed test instructions:

  • Open any WooCommerce Admin page in IE11
  • Verify it renders

Copy link
Contributor

@timmyc timmyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the bug on master via browserstack session, and that this branch fixes it. Also tested various dashboard and reporting functionality on IE11 and did not encounter any other regressions.

@jeffstieler jeffstieler merged commit fea89bb into master Jul 24, 2019
@jeffstieler jeffstieler deleted the fix/2693-ie11-broken branch July 24, 2019 17:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tool: monorepo infrastructure type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IE 11: App is broken
2 participants