Merge pull request #7638 from wordpress-mobile/issue/7635-update-sign…

…up-analytics Issue/7635 update signup analytics
woocommerce · Apr 17, 2018 · 4067ab1 · 4067ab1
2 parents 3d1d5e5 + bb3840a
commit 4067ab1
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/WordPressLoginFlow/src/main/java/org/wordpress/android/login/LoginAnalyticsListener.java b/WordPressLoginFlow/src/main/java/org/wordpress/android/login/LoginAnalyticsListener.java
@@ -28,9 +28,10 @@ public interface LoginAnalyticsListener {
     void trackPasswordFormViewed();
     void trackSignupEmailToLogin();
     void trackSignupMagicLinkFailed();
+    void trackSignupMagicLinkOpened();
+    void trackSignupMagicLinkOpenEmailClientClicked();
     void trackSignupMagicLinkSent();
     void trackSignupMagicLinkSucceeded();
-    void trackSignupSocial2faNeeded();
     void trackSignupSocialAccountsNeedConnecting();
     void trackSignupSocialButtonFailure();
     void trackSignupSocialToLogin();

diff --git a/WordPressLoginFlow/src/main/java/org/wordpress/android/login/LoginListener.java b/WordPressLoginFlow/src/main/java/org/wordpress/android/login/LoginListener.java
@@ -34,7 +34,7 @@ interface SelfSignedSSLCallback {
     void helpMagicLinkRequest(String email);
 
     // Login Magic Link Sent callbacks
-    void openEmailClient();
+    void openEmailClient(boolean isLogin);
     void helpMagicLinkSent(String email);
 
     // Login email password callbacks

diff --git a/WordPressLoginFlow/src/main/java/org/wordpress/android/login/LoginMagicLinkSentFragment.java b/WordPressLoginFlow/src/main/java/org/wordpress/android/login/LoginMagicLinkSentFragment.java
@@ -55,7 +55,7 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle sa
             @Override
             public void onClick(View v) {
                 if (mLoginListener != null) {
-                    mLoginListener.openEmailClient();
+                    mLoginListener.openEmailClient(true);
                 }
             }
         });

diff --git a/WordPressLoginFlow/src/main/java/org/wordpress/android/login/SignupGoogleFragment.java b/WordPressLoginFlow/src/main/java/org/wordpress/android/login/SignupGoogleFragment.java
@@ -185,7 +185,6 @@ public void onSocialChanged(AccountStore.OnSocialChanged event) {
             switch (event.error.type) {
                 // WordPress account exists with input email address, and two-factor authentication is required.
                 case TWO_STEP_ENABLED:
-                    mAnalyticsListener.trackSignupSocial2faNeeded();
                     mAnalyticsListener.trackSignupSocialToLogin();
                     mLoginListener.showSignupToLoginMessage();
                     // Dispatch social login action to retrieve data required for two-factor authentication.

diff --git a/WordPressLoginFlow/src/main/java/org/wordpress/android/login/SignupMagicLinkFragment.java b/WordPressLoginFlow/src/main/java/org/wordpress/android/login/SignupMagicLinkFragment.java
@@ -74,7 +74,7 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle sa
             @Override
             public void onClick(View view) {
                 if (mLoginListener != null) {
-                    mLoginListener.openEmailClient();
+                    mLoginListener.openEmailClient(false);
                 }
             }
         });