-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS][Non Simple Products] Checkout variations #12927
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
…e/12925-checkout-variations # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/cart/WooPosCartViewModel.kt
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #12927 +/- ##
=========================================
Coverage 39.75% 39.76%
- Complexity 5992 6000 +8
=========================================
Files 1268 1268
Lines 73262 73317 +55
Branches 10046 10051 +5
=========================================
+ Hits 29124 29153 +29
- Misses 41571 41593 +22
- Partials 2567 2571 +4 ☔ View full report in Codecov by Sentry. |
…e/12925-checkout-variations
…e/12925-checkout-variations
…e/12925-checkout-variations
…e/12925-checkout-variations
…e/12925-checkout-variations
…e/12925-checkout-variations
…e/12925-checkout-variations
…e/12925-checkout-variations
Version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes: #12925
Description
This PR supports check out of the variations successfully. With this PR, you should be able to select, add, and then checkout variations successfully on POS mode.
Testing information
Try selecting different variations, add those to the cart, and then proceed to checkout and complete the transaction. It should finish successfully and you should be able to see all the products correctly in the order detail screen.
The tests that have been performed
Checkout successfully
Correct product details in Order details screen
Images/gif
checkout_variations.mp4
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: