Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkstyle and ktlint updates #185

Merged
merged 4 commits into from
Apr 19, 2018
Merged

Checkstyle and ktlint updates #185

merged 4 commits into from
Apr 19, 2018

Conversation

aforcier
Copy link
Contributor

Brings in the latest style configs, and bumps ktlint to 0.21.0.

The bulk of the changes come from wordpress-mobile/WordPress-FluxC-Android#747 and wordpress-mobile/WordPress-FluxC-Android#755.

@aforcier aforcier added the MVLP label Apr 18, 2018
@AmandaRiu AmandaRiu self-requested a review April 18, 2018 21:42
@AmandaRiu AmandaRiu self-assigned this Apr 18, 2018
AmandaRiu
AmandaRiu approved these changes Apr 19, 2018
View reviewed changes
Copy link
Contributor

@AmandaRiu AmandaRiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aforcier Looks good! Ran into some issues when I tried to run the instrumentation tests, but those issues are not related to any changes in this ticket. I'll address them in a separate PR.
:shipit:

@AmandaRiu AmandaRiu merged commit 6eea098 into develop Apr 19, 2018
@AmandaRiu AmandaRiu deleted the feature/lint-updates branch April 19, 2018 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmandaRiu AmandaRiu AmandaRiu approved these changes

Assignees

@AmandaRiu AmandaRiu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aforcier @AmandaRiu