Tracks for JITM displayed #7657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tm-displayed-track
…dismiss-tapped-track
…tm-displayed-track
…ta-tapped-track # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/mystore/MyStoreViewModel.kt
…dismiss-tapped-track # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/mystore/MyStoreViewModel.kt
…itm-dismiss-success-track # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/mystore/MyStoreViewModel.kt # WooCommerce/src/test/kotlin/com/woocommerce/android/ui/mystore/MyStoreViewModelTest.kt
You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:
|
…tm-displayed-track # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/mystore/MyStoreViewModel.kt
…dismiss-tapped-track
…itm-dismiss-success-track
AnirudhBhat
added
feature: mobile payments
Generated by 🚫 dangerJS |
malinajirka
approved these changes
Oct 27, 2022
| @@ -237,6 +237,10 @@ class AnalyticsTracker private constructor(private val context: Context) { | |||
| const val KEY_HAS_MULTIPLE_SHIPPING_LINES = "has_multiple_shipping_lines" | |||
| const val KEY_HAS_MULTIPLE_FEE_LINES = "has_multiple_fee_lines" | |||
|
|
|||
| const val JITM_ID = "jitm_id" | |||
| const val JITMS = "jitms" | |||
There was a problem hiding this comment.
❓ This doesn't seem to be used. Is it necessary?
pachlava
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
Even though the Instrumented Tests fail because of the missing WireMock request matcher, I believe this will be solved after the current branch eventually ends in issue/7559-jitm-api branch, to which I took the liberty of adding (20bb09e) the missing WireMock file.
As per the jitm_displayed event, I confirm that it's indeed tracked:
…tm-displayed-track # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/mystore/MyStoreViewModel.kt
…ta-tapped-track # Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/mystore/MyStoreViewModel.kt
…dismiss-tapped-track
…itm-dismiss-success-track
…cess-track Tracks for JITM dismiss success
…ped-track Tracks for JITM dismiss tapped
…track Tracks for JITM CTA tapped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #7625
Description
This PR has analytics to track when the JITM is displayed on the screen. Please note that this tracks only JITM display and not the JITM fetch success. There might be a chance that the JITM API succeeds but the JITM list will be empty and hence, not displayed.
*_jitm_displayedProperties:
source :
my_storejitm_id : {jitm_id}
jitm_group : {FEATURE_CLASS}
More info: pdfdoF-1zc-p2
Testing instructions
Pre-requisite
As mentioned in this post (pdfdoF-1vt-p2) make sure you have installed any one of the mentioned barcode plugin installed on your store. For example - you can install A4 Barcode Generator
Your store must be set up in the US. JITM is not supported in any other country.
RELEASE-NOTES.txtif necessary.