Add blocks-hydration-experiments blocks
#80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right now, it seems to work fine in the frontend, but not in the editor. It breaks when you reload a post with BHE blocks on it. 🤔 EDIT: it is this issue with the code editor. @c4rl0sbr4v0 has pointed it out below. |
|
Size Change: +10.3 kB (+1%) Total Size: 882 kB
ℹ️ View Unchanged
|
Could be for this reason? |
That must be it. I haven't noticed that I left the code editor enabled, so it crashed every time I tried to edit the post with the BHE blocks. It works with the regular block editor. Thanks, @c4rl0sbr4v0. 🙂 |
Script Dependencies ReportThe
This comment was automatically generated by the |
|
It turned out that the recent problem I'd experienced in this branch was the already-known race-condition issue. 😅 |
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label - otherwise it will automatically be closed after 10 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I posted in the tracking issue, I plan to write some blocks from scratch ― specifically the Checkout and inner blocks. That means creating new blocks.
This PR adds the blocks we already implemented in WordPress/block-hydration-experiments to understand better what is needed to include more blocks in the repo. This also includes the files needed to share context between blocks.