Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Convert edit.js to edit.tsx and replace propTypes with TypeScript definitions #9522

Closed
Tracked by #42364
nielslange opened this issue May 19, 2023 · 0 comments · Fixed by #9823
Closed
Tracked by #42364

Convert edit.js to edit.tsx and replace propTypes with TypeScript definitions #9522

nielslange opened this issue May 19, 2023 · 0 comments · Fixed by #9823
Assignees
@albarin
Labels
type: cooldown Things that are queued for a cooldown period (assists with planning). type: enhancement The issue is a request for an enhancement. type: refactor The issue/PR is related to refactoring.

Comments

@nielslange
Copy link
Member

Problem

assets/js/blocks/reviews/reviews-by-product/edit.js is a JS file and uses propTypes definitions.

Expected outcome

  1. Convert the file from edit.js to edit.tsx.
  2. Replace propTypes with TypeScript definitions.
@nielslange nielslange added type: enhancement The issue is a request for an enhancement. type: refactor The issue/PR is related to refactoring. type: cooldown Things that are queued for a cooldown period (assists with planning). labels May 19, 2023
@nielslange nielslange mentioned this issue Dec 11, 2023
Open
@hritikchaudhary hritikchaudhary mentioned this issue Jun 1, 2023
Closed
7 tasks
@albarin albarin self-assigned this Jun 14, 2023
@albarin albarin mentioned this issue Jun 14, 2023
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@albarin albarin

Labels
type: cooldown Things that are queued for a cooldown period (assists with planning). type: enhancement The issue is a request for an enhancement. type: refactor The issue/PR is related to refactoring.
Projects
None yet
Milestone
No milestone
2 participants
@albarin @nielslange