This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Convert edit.js
to edit.tsx
and replace propTypes
with TypeScript definitions
#9823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albarin
added
the
skip-changelog
PRs that you don't want to appear in the changelog.
label
Jun 14, 2023
woocommercebot
requested review from
a team and
imanish003
and removed request for
a team
June 14, 2023 12:15
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
assets/js/blocks/reviews/reviews-by-product/edit.tsx
|
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
albarin
added
type: enhancement
The issue is a request for an enhancement.
type: refactor
The issue/PR is related to refactoring.
type: cooldown
Things that are queued for a cooldown period (assists with planning).
labels
Jun 14, 2023
imanish003
reviewed
Jun 15, 2023
imanish003
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @albarin, thank you for making the changes 🚀 I've noticed that there are multiple TypeScript errors in the file assets/js/blocks/reviews/reviews-by-product/edit.tsx
. I'm unsure if addressing these errors is part of the scope of this task, so I am pre-approving the PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
skip-changelog
PRs that you don't want to appear in the changelog.
type: cooldown
Things that are queued for a cooldown period (assists with planning).
type: enhancement
The issue is a request for an enhancement.
type: refactor
The issue/PR is related to refactoring.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the
Reviews by Product
edit.js
file to use typescript.Fixes #9522
Testing
User-Facing Testing
Reviews by Product
block.WooCommerce Visibility