This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Auto-insert the Mini Cart block after the Navigation block #10649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the feature plugin.
woocommercebot
requested review from
a team and
danieldudzic
and removed request for
a team
…er-navigation-block
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
|
Hey @nefeline, thanks for working on this! 🙏 I see some issues with this approach because we cannot really control into which patterns (or navigation blocks) it will be inserted. With our current patterns, we could end up with multiple Mini-cart blocks on the page, or in unexpected positions. |
|
Thanks for the review @albarin !
Good point, I'll move this PR back to in progress and spend some time investigating if we can narrow down its usage to core's header template parts: I suspect there's more work required on the GB side in order for us to rely on this feature conditionally to auto-insert blocks. |
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
github-actions
bot
removed
the
status: stale
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
|
This is superseded by #11745 - so I'll close this. Thanks for your early experiments with this Patricia! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes woocommerce/woocommerce#42385
Why
Following up on the work made on WordPress/gutenberg#51449, the Mini Cart block can now be auto-inserted right after the Navigation block.
Since this is still an experimental feature within Gutenberg, we are here restricting its usage to the feature plugin at this first moment.
Testing Instructions
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog