This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Fix cart block isLarge console error in the editor when running WordPress 5.6 beta #3408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -24 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
nerrad
reviewed
Nov 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we care that this also impacts how this was used/rendered in earlier WP versions?
@nerrad it's such a minor detail it's likely better to standardise, rather than introduce custom styles for core components. |
budzanowski
approved these changes
Nov 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Nov 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isLarge
is not longer a supported prop on@wordpress/components
button (see WordPress/gutenberg#16541). This PR removes usage.There was only a minor difference between isLarge and regular buttons, and it affected some placeholder states and the view switcher.
Fixes #3382
Screenshots
These were the affected buttons in the ViewSwitcher:
How to test the changes in this Pull Request:
No other steps were required to see the error previously.
Changelog