This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix sanitization callback #5060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
opr
and removed request for
a team
senadir
added
focus: rest api
|
Size Change: -4.01 kB (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
senadir
commented
Nov 5, 2021
| @@ -0,0 +1,225 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Reviewed this new test and it's looks fine to me! Thank you for writing it.
|
e2e test fail is unrelated. Merging. |
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
* Fix sanitization callback * Add test case to confirm sanitization callbacks work for nested properties Co-authored-by: Mike Jolley <mike.jolley@me.com>
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
* Fix sanitization callback * Add test case to confirm sanitization callbacks work for nested properties Co-authored-by: Mike Jolley <mike.jolley@me.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is cherry-picked from #5045
This fixed an error where data passed to the Store API via post would be incorrectly represented in the $request object after data sanitization.
Previously it would look over all items in the object recursively but due to this condition, would return the first sanitized value:
Other data in the
extensionsobject would then be skipped.The fix is to place all values into an array and return them once all properties have been sanitized.
Testing steps
Since these changes only impact developers, there are no user facing testing steps to perform. I have however added a test case to confirm nested properties are no longer destroyed. Ensure php tests pass with this change.
Changelog