This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Change source value on WooCommerce block templates to be plugin #5215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of woocommerce
tjcafferkey
added
type: enhancement
rubikuserbot
requested review from
a team and
frontdevde
and removed request for
a team
tjcafferkey
changed the title
|
Size Change: 0 B Total Size: 1.12 MB ℹ️ View Unchanged
|
38 tasks
frontdevde
approved these changes
Nov 26, 2021
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to WordPress/gutenberg#36597 (comment)
Change the
sourceattribute of the templates to be consistent with its intended use, where in this case the value should beplugininstead ofwoocommerceManual Testing
How to test the changes in this Pull Request:
block-templatesdirectory to ensure the theme's template supersedes the plugins by loading it in the Site Editor and on the frontendUser Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).