This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Make it so WooCommerce template names are not editable #5385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
focus: FSE
rubikuserbot
requested review from
a team and
gigitux
and removed request for
a team
Aljullu
changed the title
|
Size Change: 0 B Total Size: 819 kB ℹ️ View Unchanged
|
Aljullu
force-pushed
the
fix/5281-wc-templates-title-editable
branch
from
7e4f122
to
c312e0d
Compare
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
tjcafferkey
pushed a commit
that referenced
this pull request
Dec 22, 2021
* Make it so WooCommerce template names is not editable * Remove source='plugin' from templates
tjcafferkey
added a commit
that referenced
this pull request
Dec 22, 2021
* Empty commit for release pull request * Fix saving WooCommerce templates in WP 5.9 beta 3 (#5408) * fix not found template for the template editor (#5425) * Check for woocommerce as the theme before rendering with a more user friendly plugin name (#5420) * Make it so WooCommerce template names are not editable (#5385) * Make it so WooCommerce template names is not editable * Remove source='plugin' from templates * Load required scripts in LegacyTemplate.php render method (#5346) * Fix reverting WC templates (#5342) * Update block theme conditionals in BlockTemplateController (#5335) * Check if the current theme has a product-archive block template in the absence of a product taxonomy block template. (#5380) * Add archive-product template into block template hieachy * Add archive-product condition to product tag block template render method * Move taxonomy hierarchy filter to WC core * Undo template amends * Duplicate the themes archive-product template if it has one for taxonomy block templates * Review feedback * Use TextDomain instead of Name * use correct if/else syntax * Remove unncessary boolean syntax * Update readme.txt for 6.5.1 changelog * Testing notes for 6.5.1 * Bumping version strings to new version. Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com> Co-authored-by: Luigi Teschio <gigitux@gmail.com> Co-authored-by: Tom Cafferkey <tjcafferkey@gmail.com>
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5281.
It turns out that
is_customin a template object means that it's a template created by the user, not a template from the theme/plugin edited by the user. So in WooCommerce template we always have to set it tofalse.In this PR I also removed this line:
according to the comment docs,
$sourcecan only have two values:themeorcustom. So I think it's better to leave it blank, so it uses the default value (theme).Manual Testing
User Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).
Changelog