This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix: navigate through Mini Cart contents with keyboard #6731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinhtungdu
added
status: needs review
type: bug
|
Size Change: +175 B (0%) Total Size: 873 kB
ℹ️ View Unchanged
|
Aljullu
approved these changes
Jul 22, 2022
Comment on lines
160
to
164
| &:focus { | ||
| box-shadow: 0 0 0 2px $studio-blue; | ||
| box-shadow: inset 0 0 0 1px $white, 0 0 0 2px $studio-blue; | ||
| outline: 3px solid transparent; | ||
| } |
There was a problem hiding this comment.
I wonder if we could avoid repeating the styles from assets/js/base/components/button/style.scss, something like this: https://github.com/woocommerce/woocommerce-blocks/compare/fix/6575...fix/6575-style-suggestion?expand=1.
I know it doesn't simplify the code much because we need to use :not() in a couple of instances. But at the same time, it means the Mini Cart buttons are better aligned with the default styles, so I think it's probably a good thing in the long term.
Ideally, some day assets/js/base/components/button/style.scss will use currentColor instead of $gray-900, so we will be able to just reuse the styles from there, but that requires adding global styles to the Cart and Checkout blocks, so it's outside of our control right now.
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
|
@Aljullu Thank you so much for your great suggestion! I applied it to this PR. |
|
The release ZIP for this PR is accessible via: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6575
This PR fixes the keyboard navigation issue for the Mini Cart Contents inner blocks.
Accessibility
prefers-reduced-motionScreenshots
I tested this PR against most popular desktop browsers:
Safari (needs to press Option + Tab to navigate to links)
Screen.Recording.2022-07-21.at.23.21.33.mov
Opera
Screen.Recording.2022-07-21.at.23.20.05.mov
Edge
Screen.Recording.2022-07-21.at.23.19.46.mov
Firefox (Need to adjust keyboard setting on macOS, see https://pointclearmedia.com/2020/01/03/how-to-fix-firefox-tabindex-not-working/)
Screen.Recording.2022-07-21.at.23.17.18.mov
Chrome
Screen.Recording.2022-07-21.at.23.15.01.mov
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Changelog