This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Only show items if there are multiple packages in the cart #6899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opr
added
status: needs review
type: bug
opr
added
the
focus: blocks
rubikuserbot
requested review from
a team and
tarunvijwani
and removed request for
a team
|
The release ZIP for this PR is accessible via: |
|
Size Change: -97 B (0%) Total Size: 865 kB
ℹ️ View Unchanged
|
senadir
approved these changes
Aug 16, 2022
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
tarunvijwani
pushed a commit
that referenced
this pull request
Aug 17, 2022
* Add global styles to Product Categories List block in WC core (#6906) * add side effect to package (#6904) * Add _blank to terms link (#6908) * Only show items if there are multiple packages in the cart (#6899) * Price Filter Block Design update (#6877) * make toggle control full width * add inlineInput attribute * add inlineInput sidebar setting * add inlineInput help text * style the filter button * style price input * wip: reset button * clicking on reset button will reset the price query * support inline input fields * price text styling update * fix reset button font size * add loading placeholder to all elements * fix filter button style * update range slider thumb and track style * fix loading placeholder for non empty query * move reset button into FilterSubmitButton component * try: render placeholder serverside * update filter button label * Revert "try: render placeholder serverside" This reverts commit 98f08ef. * remove LoadingPlaceholder component * remove Price: prefix from the current displayed price range * update labels * extract reset button as a dedicated component * update price text section * update reset button behavior * avoid breaking filter submit button style for other filter blocks * rename block to Filter by Price * fix e2e test * remove border support * adjust padding for elments * rename panel title * Make the inline option enabled by default and fix frontend rendering * Make the `Price Range Selector` uppercase * Show `Reset` button only when a selection has been made * Revert the `save` change to avoid the 'Block Recovery Prompt' Co-authored-by: Alba Rincón <alba.rincon@automattic.com> * Release: 8.3.0 (#6897) * Empty commit for release pull request * Bump version numbers and add changelog * Add testing notes * Add global styles to Product Categories List block in WC core * add side effect to package * Update testing instructions * Empty commit * Fix linting * Update zip file with latest changes * Fix linting * Update changelog entries * Bumping version strings to new version. Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Tarun Vijwani <tarun.vijwani@automattic.com> Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com> Co-authored-by: Nadir Seghir <nadir.seghir@gmail.com> Co-authored-by: Saad Tarhi <saad.trh@gmail.com> * Update version to 8.4.0-dev * Empty commit for release pull request * Add change log * Add testing instructions * Fix the version number in testing instructions * Bumping version strings to new version. Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com> Co-authored-by: Seghir Nadir <nadir.seghir@gmail.com> Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> Co-authored-by: Tung Du <dinhtungdu@gmail.com> Co-authored-by: Alba Rincón <alba.rincon@automattic.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Tarun Vijwani <tarun.vijwani@automattic.com> Co-authored-by: Saad Tarhi <saad.trh@gmail.com>
senadir
added a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Aug 18, 2022
* Add global styles to Product Categories List block in WC core (woocommerce#6906) * add side effect to package (woocommerce#6904) * Add _blank to terms link (woocommerce#6908) * Only show items if there are multiple packages in the cart (woocommerce#6899) * Price Filter Block Design update (woocommerce#6877) * make toggle control full width * add inlineInput attribute * add inlineInput sidebar setting * add inlineInput help text * style the filter button * style price input * wip: reset button * clicking on reset button will reset the price query * support inline input fields * price text styling update * fix reset button font size * add loading placeholder to all elements * fix filter button style * update range slider thumb and track style * fix loading placeholder for non empty query * move reset button into FilterSubmitButton component * try: render placeholder serverside * update filter button label * Revert "try: render placeholder serverside" This reverts commit 98f08ef. * remove LoadingPlaceholder component * remove Price: prefix from the current displayed price range * update labels * extract reset button as a dedicated component * update price text section * update reset button behavior * avoid breaking filter submit button style for other filter blocks * rename block to Filter by Price * fix e2e test * remove border support * adjust padding for elments * rename panel title * Make the inline option enabled by default and fix frontend rendering * Make the `Price Range Selector` uppercase * Show `Reset` button only when a selection has been made * Revert the `save` change to avoid the 'Block Recovery Prompt' Co-authored-by: Alba Rincón <alba.rincon@automattic.com> * Release: 8.3.0 (woocommerce#6897) * Empty commit for release pull request * Bump version numbers and add changelog * Add testing notes * Add global styles to Product Categories List block in WC core * add side effect to package * Update testing instructions * Empty commit * Fix linting * Update zip file with latest changes * Fix linting * Update changelog entries * Bumping version strings to new version. Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Tarun Vijwani <tarun.vijwani@automattic.com> Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com> Co-authored-by: Nadir Seghir <nadir.seghir@gmail.com> Co-authored-by: Saad Tarhi <saad.trh@gmail.com> * Update version to 8.4.0-dev * Empty commit for release pull request * Add change log * Add testing instructions * Fix the version number in testing instructions * Bumping version strings to new version. Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com> Co-authored-by: Seghir Nadir <nadir.seghir@gmail.com> Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com> Co-authored-by: Tung Du <dinhtungdu@gmail.com> Co-authored-by: Alba Rincón <alba.rincon@automattic.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Tarun Vijwani <tarun.vijwani@automattic.com> Co-authored-by: Saad Tarhi <saad.trh@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @senadir for pointing out this bug. This change will only show the items in the shipping packages if there are multiple packages.
If there's a single package, we don't need to show which items are in it, because it'll contain all items. If there are multiple packages we should show which items are in each package.
Screenshots
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Changelog