This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix Best Selling Products block ordering #7025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjcafferkey
added
type: bug
rubikuserbot
requested review from
a team and
gigitux
and removed request for
a team
tjcafferkey
requested review from
albarin and
Aljullu
and removed request for
gigitux
|
The release ZIP for this PR is accessible via: |
Aljullu
approved these changes
Aug 31, 2022
There was a problem hiding this comment.
LGTM. Thanks for investigating and fixing this issue @tjcafferkey!
Can you fill the WooCommerce Visibility and Sprint from the PR description/sidebar before merging? 🙏
|
Size Change: 0 B Total Size: 871 kB ℹ️ View Unchanged
|
tjcafferkey
added a commit
that referenced
this pull request
Aug 31, 2022
tjcafferkey
added a commit
that referenced
this pull request
Aug 31, 2022
tjcafferkey
added a commit
that referenced
this pull request
Aug 31, 2022
tjcafferkey
added a commit
that referenced
this pull request
Sep 1, 2022
* Empty commit for release pull request * Set default orderby to popularity (#7025) * Update readme.txt with 8.3.2 changelog * 8.3.2 testing notes * Update testing instructions for 8.3.2 * Bumping version strings to new version. Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Tom Cafferkey <tjcafferkey@gmail.com>
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best Selling Products block was showing latest products, rather than the best selling. This is due to the default orderby property being set to date rather than popularity which was changed in this commit 8b3c7bc
Fixes #7017
Accessibility
prefers-reduced-motionOther Checks
Screenshots
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Performance Impact
Changelog