This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Update Active Filters "remove filter" icon to use Icon component #7035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielwrobert
added
type: enhancement
|
The release ZIP for this PR is accessible via: |
danielwrobert
changed the title
|
Size Change: -145 B (0%) Total Size: 875 kB
ℹ️ View Unchanged
|
danielwrobert
force-pushed
the
update/active-filters-remove-btns
branch
from
d835ffa
to
2595e96
Compare
rubikuserbot
requested review from
a team and
tjcafferkey
and removed request for
a team
danielwrobert
force-pushed
the
update/active-filters-remove-btns
branch
3 times, most recently
from
20d07b3
to
884010c
Compare
|
Hey @danielwrobert the colors for the "X" look different in the PR than they do on the Figma designs screenshotted below. Is this expected?
|
danielwrobert
force-pushed
the
update/active-filters-remove-btns
branch
from
884010c
to
8a485c5
Compare
|
@tjcafferkey yes, this is expected. The decision to update these remove buttons came afterwards. These remove buttons should now be the same as the Chips view, which use the Core That said, I'll leave it to @vivialice to make the final call to confirm this is what we're looking for visually! |
tjcafferkey
approved these changes
Sep 6, 2022
|
Looks good to me! Thanks for consolidating these. |
To be consistent with the button icon used on the Chips view, this replaces the native svg element used in the List view with the same Icon component from core.
There is currently no top margin when the active filters contain a price filter in the list view. This is because the filters only contain a range and do not render a child list. This update will target that price filter item and add a top margin that is consistent with the other active filters.
danielwrobert
force-pushed
the
update/active-filters-remove-btns
branch
from
8a485c5
to
47ef7ec
Compare
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
…commerce#7035) * Update "remove filter" icon to use Icon component. To be consistent with the button icon used on the Chips view, this replaces the native svg element used in the List view with the same Icon component from core. * Add proper margin to active filters by price list. There is currently no top margin when the active filters contain a price filter in the list view. This is because the filters only contain a range and do not render a child list. This update will target that price filter item and add a top margin that is consistent with the other active filters.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be consistent with the button icon used on the Chips view, this replaces the native
svgelement used in the List view with the sameIconcomponent from WP Core.Fixes #6915
Screenshots
Testing
WooCommerce Visibility
Changelog