This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 219
Wrap the Single Product Template in a div with the product class #8364
Merged
gigitux
merged 13 commits into
trunk
from
fix/8314-blockifying-single-product-template-investigate-how-to-apply-wc-core-styles-to-product-template
Feb 15, 2023
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
deaf86e
wrap the Single Product Template in a div with the product class
gigitux 95a05a4
improve logic and increase coverage of unit test
gigitux 1568ec2
improve logic and increase coverage of unit test
gigitux 379548a
Merge branch 'trunk' into fix/8314-blockifying-single-product-templat…
gigitux e82ab27
fix test
gigitux 36d5ebf
format HTML
gigitux 4e76b07
fix edge case
gigitux 82184a0
Merge branch 'trunk' of https://github.com/woocommerce/woocommerce-bl…
gigitux 6413df8
address feedback
gigitux c8cd88e
Merge branch 'trunk' of https://github.com/woocommerce/woocommerce-bl…
gigitux 9e01f97
Merge branch 'trunk' into fix/8314-blockifying-single-product-templat…
gigitux 66f06e4
fix name block and fix check
gigitux 57cea7c
wrap single product template only on the frontend
gigitux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong opinion, but I'm curious to know why you defined a Group block instead of simply a
div
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using
parse_blocks
function to generate the new structure. In the WordPress template markup, the div is represented with a blockgroup
. This is the reason I decided to define a Group block.