This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Enable Product Image Gallery only for experimental builds #8575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
added
type: enhancement
woocommercebot
requested review from
a team and
Aljullu
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
gigitux
added
status: blocker
|
Size Change: +5 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
Aljullu
approved these changes
Feb 28, 2023
There was a problem hiding this comment.
Code LGTM and it's testing as described. But a couple of questions:
Why are we gating it to experimental builds? Is there anywhere were I can read about this decision?Is this a 9.7.0 blocker? Otherwise the block will be released so we can't hide it in the future.
Update: never mind, I see it was discussed here: p1677578251632219-slack-C02UBB1EPEF.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the Product Image Gallery only for the experimental builds.
Testing
Automated Tests
User Facing Testing
npm run build:deploy.Product Image Galleryblock. Be sure that it is visible.WooCommerce Visibility