This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Move CartLineItemsTable from the Cart block directory to base-components #8644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
type: refactor
woocommercebot
requested review from
a team and
thealexandrelara
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
assets/js/base/components/cart-checkout/cart-line-items-table/cart-line-item-row.tsx
|
|
Size Change: -56 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
thealexandrelara
approved these changes
Mar 7, 2023
This was referenced Mar 8, 2023
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7176.
CartLineItemsTablewas used in Cart and Mini Cart blocks, however, its code was inside the Cart block directory. With this PR, we move it to the sharedbase/componentsfolder to make it clearer it's used in more than one block.Testing
User Facing Testing
This PR shouldn't produce any changes, so testing is focused on making sure there are no regressions:
WooCommerce Visibility