This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 221
Get product by ID if there's more products returned from useStoreProducts #9079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release ZIP for this PR is accessible via:
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
assets/js/shared/hocs/with-product-data-context.js
|
Size Change: +17 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
kmanijak
changed the title
Get product by ID if there's more products returned from useStoreProd…
Get product by ID if there's more products returned from useStoreProducts
Apr 18, 2023
kmanijak
added
the
block-type: product-query
Issues related to/affecting all product-query variations.
label
Apr 18, 2023
woocommercebot
requested review from
a team and
Aljullu
and removed request for
a team
April 18, 2023 07:46
Aljullu
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an improvement found while working on #8131. When there are more products returned from
useStoreProducts
, the first product was taken as the correct one, while we can take it based onid
.Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Performance Impact
Changelog