This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix image editor in Featured Product/Category blocks on WP 6.2 #9142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
type: bug
woocommercebot
requested review from
a team and
kmanijak
and removed request for
a team
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
assets/js/blocks/featured-items/image-editor.tsx
|
|
Size Change: +453 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
kmanijak
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
It works and no errors/warnings are thrown on 6.2 and neither 6.1 👍
I left one comment with potential improvement, but still pre-approving.
Also, I spotted that the edited (zoomed) image is actually cropped (top image: edited, bottom image: untouched). But I checked and it behaved like that before those changes, so maybe that's expected and definitely, it's not in the scope of this PR.
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
|
Thanks for the review, @kmanijak!
Good catch! That's because the block has a separate Image Fit option.
Setting it to Cover makes it expand to the entire available space. I agree that's confusing, but I'm not sure how we could improve it. 🤔 |
Aljullu
added a commit
that referenced
this pull request
Apr 20, 2023
Aljullu
added a commit
that referenced
this pull request
Apr 20, 2023
Aljullu
added a commit
that referenced
this pull request
Apr 20, 2023
Aljullu
added a commit
that referenced
this pull request
Apr 21, 2023
Aljullu
added a commit
that referenced
this pull request
Apr 21, 2023
Aljullu
added a commit
that referenced
this pull request
Apr 21, 2023
Aljullu
added a commit
that referenced
this pull request
Apr 21, 2023
* Empty commit for release pull request * Add 10.0.3 changelog * Update versions to 10.0.3 * Fix image editor in Featured Product/Category blocks on WP 6.2 (#9142) * Add 10.0.3 testing steps --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com>
Aljullu
added a commit
that referenced
this pull request
Apr 21, 2023
* Empty commit for release pull request * Empty commit for release pull request * Add 9.8.5 changelog * Update versions to 9.8.5 * Fix image editor in Featured Product/Category blocks on WP 6.2 (#9142) * Add 9.8.5 testing steps --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com>
gigitux
added a commit
that referenced
this pull request
May 5, 2023
* Empty commit for release pull request * Add 10.0.3 changelog * Update versions to 10.0.3 * Fix image editor in Featured Product/Category blocks on WP 6.2 (#9142) * Add 10.0.3 testing steps * Empty commit for release pull request * Check that the customized fallback template is archive-product before unsetting the source property (#9330) * use 'enqueue_block_assets' is available (#9332) * Remove esc_url() on self generated link to edit the Mini Cart template since it gets escaped in JS (#9348) * Add changelog entries to readme.txt * Update version number in several files * Add testing notes for the release * Add #9332 to testing notes * Add testing on frontend for #9332 --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com> Co-authored-by: Tom Cafferkey <tjcafferkey@gmail.com> Co-authored-by: Luigi Teschio <gigitux@gmail.com> Co-authored-by: Alexandre Lara <allexandrelara@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9100.
The issue was caused because we were using a Gutenberg component which is no longer available in WP 6.2 (
ImageEditingProvider), this PR refactors the code so it works without that component.Testing
User Facing Testing
wp-admin> Products > Categories and edit a category to add an image):WooCommerce Visibility
Changelog