Investigate coretelephony sending multiple errors to console.log when running simulators

[mindgraffiti]

The console.log has recently been spitting out a large number of these error messages:

[NetworkInfo] Descriptors query returned error: Error Domain=NSCocoaErrorDomain Code=4099 "The connection to service named com.apple.commcenter.coretelephony.xpc was invalidated." UserInfo={NSDebugDescription=The connection to service named com.apple.commcenter.coretelephony.xpc was invalidated.}

It could be connected to the upgrade to iOS12 and our use of the Contacts framework.
Source: https://forums.developer.apple.com/thread/108883 | https://forums.developer.apple.com/message/326361#326361

[bummytime]

So just dropping an update — looks like the source of these errors are from the Track lib here:

https://github.com/Automattic/Automattic-Tracks-iOS/blob/develop/Automattic-Tracks-iOS/TracksDeviceInformation.m#L44-L67

[mindgraffiti]

Background: Xcode 10 and Swift 4.2 ignores the macro TARGET_OS_IPHONE. It's not even deprecated any more, it's obsolete. Unfortunately, that meant that a code block was no longer getting ignored in the simulator.

[mindgraffiti]

Additional References:
https://stackoverflow.com/questions/24869481/detect-if-app-is-being-built-for-device-or-simulator-in-swift