Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use basic redirect gateway when checkout smart buttons disabled (3347) #2714

Merged
merged 9 commits into from
Oct 24, 2024

Conversation

AlexP11223
Copy link
Contributor

Now when the smart buttons are disabled for checkout the basic redirect gateway is added instead (like the woocommerce_paypal_payments_use_place_order_button filter).

In block checkout it was already added by default unless disabled via the woocommerce_paypal_payments_blocks_add_place_order_method filter.

Also disabling this gateway when there is a subscription since it does not properly.

When the smart buttons are disabled for both classic checkout and block express checkout, the settings about subscriptions are hidden.

In settings.js I tried to refactor the toggleInputsBySelectedLocations function a bit since it is too big and difficult to understand.

Copy link
Collaborator

@Narek13 Narek13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@Dinamiko Dinamiko merged commit 9f3e8a0 into trunk Oct 24, 2024
9 checks passed
@Dinamiko Dinamiko deleted the PCP-3347-rework-location-settings branch October 24, 2024 09:10
@InpsydeNiklas InpsydeNiklas changed the title Use basic redirect gateway when checkout smart buttons disabled Use basic redirect gateway when checkout smart buttons disabled (3347) Oct 25, 2024
@InpsydeNiklas InpsydeNiklas added this to the 2.9.4 milestone Oct 25, 2024
@Dinamiko Dinamiko added the enhancement New feature or request label Nov 5, 2024
@Dinamiko Dinamiko mentioned this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants