-
Notifications
You must be signed in to change notification settings - Fork 1
Add script to build prod zip file #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning Rate limit exceeded@htdat has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 54 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughAdds a GitHub Actions workflow to build a production ZIP, a local build script and npm script to produce that ZIP, updates .gitignore to ignore build artifacts, and replaces detailed README content with a condensed product-feed overview. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ae71658 to
2203004
Compare
Co-authored-by: Jaclyn Chen <watertranquil@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.github/workflows/build-production-zip.yml(1 hunks).gitignore(1 hunks)README.md(1 hunks)bin/build-prod-zip.sh(1 hunks)package.json(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-10-22T06:06:47.231Z
Learnt from: RadoslavGeorgiev
Repo: woocommerce/OpenAI-Product-Feed PR: 13
File: src/Platforms/OpenAI/ProductMapper.php:99-107
Timestamp: 2025-10-22T06:06:47.231Z
Learning: In the woocommerce/OpenAI-Product-Feed repository, exception messages should use escaping functions (like esc_html()) to sanitize translations before throwing, as translations may contain HTML. Do not suggest removing escaping from exception messages in this codebase.
Applied to files:
README.md
🪛 actionlint (1.7.8)
.github/workflows/build-production-zip.yml
24-24: shellcheck reported issue in this script: SC2086:info:1:50: Double quote to prevent globbing and word splitting
(shellcheck)
🔇 Additional comments (4)
.gitignore (1)
31-32: LGTM — appropriate to exclude build artifacts.The addition of
build/aligns with the new build pipeline and prevents generated artifacts from being committed to version control.bin/build-prod-zip.sh (1)
45-47: LGTM — robust file copying via array.Using an array for
FILES_TO_COPYand iterating withcp -ris maintainable and clear. The array makes it easy to add/remove files in the future.package.json (1)
13-13: Verify and fix indentation on "build" script entry.The indentation on line 13 may not match the rest of the file (tabs vs. spaces). Ensure all entries in the
scriptssection use consistent indentation. Past feedback flagged this as a potential issue—please verify the indentation matches the project's convention.If using tabs in other parts of the file, update line 13 to use tabs instead of spaces.
.github/workflows/build-production-zip.yml (1)
15-45: LGTM — comprehensive and well-structured CI workflow.The workflow correctly sets up PHP 7.4, caches Composer dependencies, executes the build script, and uploads the artifact with proper error handling and retention policies. The overall design is solid for a production build pipeline.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
+ remove folder after build + install composer directly in build
This reverts commit 8e6724a.
RadoslavGeorgiev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
FYI I've not tested the action, but I assume that the file was mostly carried over from another extension, and it should work.
|
yup, it worked in the last commit https://github.com/woocommerce/OpenAI-Product-Feed/actions/runs/18967534514/job/54167352735 - better link https://github.com/woocommerce/OpenAI-Product-Feed/actions/runs/18967534514?pr=29 I am going to revert the trigger commit and merge it. |
Fixes: WOOPTP-55
Description
Testing instructions
Checklist
npm run test:phpdoes not return errors.npm run lint:phpdoes not return errors.Summary by CodeRabbit
Documentation
Chores