Skip to content

Update manage_stock property type #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

albarin
Copy link
Contributor

@albarin albarin commented Jul 10, 2025

Closes woocommerce/woocommerce#59319

This PR updates the manage_stock product variation property to be string or boolean. Before, it was documented only as boolean, but it can also return have the parent value when the variation inherits stock settings from the parent product.

Testing steps

  1. Run the build script found in the root of this repo: ./build.sh
  2. Find the build directory created by the script, and the index.html file within. Load that file in your web browser.
  3. Search for manage_stock occurrences and check that the type is "type": ["boolean", "string"] or boolean, string when the description refers to Stock management at variation level. (it should still be only boolean when the description is for the product level Stock management at product level.).
"manage_stock":
    "required": false,
    "default": false,
    "description": "Stock management at variation level.",
    "type": ["boolean", "string"]
}
  1. Repeat step 3 for v1 and v2 documentation as well.

@albarin albarin marked this pull request as ready for review July 10, 2025 10:18
@albarin albarin requested review from a team and joshuatf and removed request for a team July 10, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC-BUG] Incorect propery type
1 participant