-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix free features is still rendered when no recommendation #33923
Fix free features is still rendered when no recommendation #33923
Conversation
Test Results SummaryCommit SHA: b5c4087
To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
3bbac6c
to
e822b23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bfa7805
to
e6bd879
Compare
@ilyasfoo Sorry, I forgot to update the submit logic so it went to an empty free features screen. I've fixed that in e6bd879. You can use this release zip file. 🙂 |
E2E is failing but I think it's unrelated.
|
b7153b6
to
b5c4087
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested well, great work @chihsuan! 🚢
Hi @chihsuan, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:
|
* Fix free features is still rendered when there is no recommendation * Add changelog * Update BusinessDetails tab to go to next step if no installable extensions * Update spinner
All Submissions:
Changes proposed in this Pull Request:
Closes #33915.
This PR adds a check
hasInstallableExtensions
before component rendering to not render free features tab when no recommendation.To make it, I moved the
getFreeExtensions
function call from<SelectiveExtensionsBundle>
to<BusinessDetails>
, as well asgetInstallableExtensions
.How to test the changes in this Pull Request:
Free features
tab, make a note of the plugins. You should seeMailPoet
andGoogle Listings and Ads
only (when Jetpack is already installed).Free features
manually.Free features
tabOther information:
pnpm changelog add --filter=<project>
?FOR PR REVIEWER ONLY: