Fix deprecated get_option notice when viewing Analytics > Orders

[mikkamp]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

When viewing Analytics > Orders a deprecated message is shown/logged. The reason this happens is because we switched to using a whitelist for allowed options, since WC 6.3. The option woocommerce_orders_report_date_tour_shown was not included in this whitelist, which is what this PR changes.

We can observe the requests for options by viewing the API requests when visiting Analytics > Orders. There we can see the request to: https://domain.test/wp-json/wc-admin/options?options=woocommerce_task_list_reminder_bar_hidden%2Cwoocommerce_orders_report_date_tour_shown%2Cwoocommerce_date_type&_locale=user

The only option that was missing from the whitelist was woocommerce_orders_report_date_tour_shown. I also checked all the other Analytics pages to ensure they aren't loading any options that weren't whitelisted.

Closes #47026
Closes #37592

How to test the changes in this Pull Request:

1. Start with testing before checking out this PR to confirm the error is logged
2. Configure site to log deprecations notices:

define( 'WP_DEBUG', true );
define( 'WP_DEBUG_LOG', true );

3. In the DB table wp_options set the option woocommerce_orders_report_date_tour_shown to no (only needed if previously viewed)
4. Visit the page Analytics > Orders and click on the Got it to acknowledge the notice
   
5. Check the log file wp-content/debug.log and confirm we see both deprecation messages for get_options and update_options

[03-Jul-2024 10:02:53 UTC] The Automattic\WooCommerce\Admin\API\Options::get_options function is deprecated since version 6.3.
[03-Jul-2024 10:02:53 UTC] The Automattic\WooCommerce\Admin\API\Options::get_options function is deprecated since version 6.3.
[03-Jul-2024 10:03:13 UTC] The Automattic\WooCommerce\Admin\API\Options::update_options function is deprecated since version 6.3.
[03-Jul-2024 10:03:13 UTC] The Automattic\WooCommerce\Admin\API\Options::update_options function is deprecated since version 6.3.
[03-Jul-2024 10:03:13 UTC] The Automattic\WooCommerce\Admin\API\Options::update_options function is deprecated since version 6.3.
[03-Jul-2024 10:03:13 UTC] The Automattic\WooCommerce\Admin\API\Options::update_options function is deprecated since version 6.3.

6. Checkout this PR and repeat steps 3 to 5, this time we shouldn't see any warnings for either get_options or update_options
7. Check all additional pages in Analytics and confirm we don't get warnings for any other page.

Changelog entry

• Automatically create a changelog entry from the details below.

• This Pull Request does not require a changelog entry. (Comment required below)

Changelog Entry Details

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Changelog Entry Comment

Comment

[github-actions]

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

[github-actions]

Hi , @woocommerce/automata

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[eason9487]

Thanks for the fix.

Confirmed the deprecated get_options and update_options notices are no longer logged. LGTM.