Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hetznercloud driver #12

Merged
merged 6 commits into from
Aug 18, 2023
Merged

Update hetznercloud driver #12

merged 6 commits into from
Aug 18, 2023

Conversation

6543
Copy link
Member

@6543 6543 commented Aug 17, 2023 •
edited
Loading

  • log caller if level is debug or trace
  • bump hetznercloud client lib to v2
  • don't panic on wrong labels settings
  • select image arch based server type

@6543
Copy link
Member Author

6543 commented Aug 17, 2023

as one can see the deploy of arm works now -> https://ci.woodpecker-ci.org/repos/8975/pipeline/60/7

but the image is not ready jet :D

@6543 6543 added the bug Something isn't working label Aug 17, 2023
@6543 6543 added this to the 0.1.1 milestone Aug 17, 2023
@6543 6543 mentioned this pull request Aug 17, 2023
Closed
@xoxys
Copy link
Member

xoxys commented Aug 17, 2023

We should enable renovate bot or similar across the WP org. These outdated dependencies all over the place are somewhat annoying.

anbraten
anbraten reviewed Aug 17, 2023
View reviewed changes
engine/stringmaps.go Outdated Show resolved Hide resolved
providers/hetznercloud/driver.go Outdated Show resolved Hide resolved
@pat-s
Copy link
Contributor

pat-s commented Aug 17, 2023

We should enable renovate bot or similar across the WP org. These outdated dependencies all over the place are somewhat annoying.

+1, there are tools for that to easily stay up-to-date with minimal human effort

@xoxys
Copy link
Member

xoxys commented Aug 17, 2023 •
edited
Loading

We should enable renovate bot or similar

Can recommend it, and it's open source, https://github.com/renovatebot/renovate

@6543
Copy link
Member Author

6543 commented Aug 17, 2023

Can agree on renovate ... in this case it was a majour bump witch renovate does not do anyway ...

@xoxys
Copy link
Member

xoxys commented Aug 17, 2023

It does, thegeeklab/drone-github-comment#254

@6543 6543 requested a review from anbraten August 17, 2023 11:42
@6543 6543 merged commit 1731530 into main Aug 18, 2023
@6543 6543 deleted the update_hetznercloud_driver branch August 18, 2023 10:30
@anbraten anbraten mentioned this pull request Aug 18, 2023
Closed
@woodpecker-bot woodpecker-bot mentioned this pull request Nov 11, 2023
Merged
1 task
@woodpecker-bot
Copy link
Contributor

🎉 This PR is included in version 0.2.0 🎉

The release is now available here

Thank you for your contribution. ❤️📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pat-s pat-s pat-s approved these changes

@xoxys xoxys xoxys approved these changes

@anbraten anbraten Awaiting requested review from anbraten

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @xoxys @pat-s @woodpecker-bot @anbraten