-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linode provider #15
Conversation
As a note. The "user-data" in this driver is a bash script to do the same job as the Hetzner driver which uses cloud-init. I battled for a long time (days) to get this working with cloud-init on Linode. However there is something funny with Linode config I could not iron out. As a workaround utilizing their "StackScripts" implementation we can create agents on demand. A public "StackScript" I have created allows this to happen from the Linode end. |
Thanks for the work. The code looks pretty well already. I just need to test it. I just found this community post regarding cloud-init support: |
Haha, yeah. That looks promising. But seems to have been coming for years already. Being in NZ I deploy resources in the closest GEO which is not in the Beta sadly. The StackScript/Bash solution works no matter anyway. I was using for a time this kind of method to get around the shortfall while using Drone Autoscaler. I did code a linode driver for that too some long time back ;) Never released it, was not sure of their licensing model. But after banging ones head re: cloud-init you just give up and find something that works and this is where the bash implementation sits ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They added cloud-init to more regions now, so maybe it is already supported in your region as well. Apart from that it lgtm.
Not sure myself either is a direct dependency. I will check out the
cloud-init again in a few days should I get time.
…On Sat, 11 Nov 2023 at 8:35 AM, Anbraten ***@***.***> wrote:
***@***.**** commented on this pull request.
They added cloud-init to more regions now, so maybe it is already
supported in your region as well. Apart from that it lgtm.
------------------------------
In go.mod
<#15 (comment)>
:
> github.com/golang/protobuf v1.5.3 // indirect
+ github.com/linode/linodego v1.20.1 // indirect
Not sure why its indirect?
—
Reply to this email directly, view it on GitHub
<#15 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7Q3YEMCT4HG774ZB5STY3YDZ6YLAVCNFSM6AAAAAA4DSYW4CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMRVGQ4TIMZYGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Awesome. Sorry for the long silence 🙈 Just poke me if I am missing it again. |
could you merge master into the feature branch :) |
Metadata/userdata/cloud-init is accessible to everything running on the agent, not only So you should not save the woodpecker token in that. I could not find anything in the documentation about how the stackscripts are retrieved by the machine on boot. |
Unless the tokens are one-time use, I haven't looked into that. |
go mod tidy run against this branch and pushed. Is now correctly shown as direct dependency |
"... This branch has conflicts that must be resolved ..." Can you merge target branch into pull head branch :) |
…to FEAT-linode-driver
|
||
var metadata *linodego.InstanceMetadataOptions | ||
|
||
// TODO: remove once linode user-data is out of beta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user data service was out of beta January 2nd 2024.
https://www.linode.com/blog/compute/customize-deployments-with-akamais-metadata-service/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is still not available in all data centres. For me the closest is ap-southeast in Sydney. This region does not have metadata service
🎉 This PR is included in version 0.2.0 🎉 The release is now available here Thank you for your contribution. ❤️📦🚀 |
This is an implementation of a driver for Linode.