Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hetznercloud network, firewall and ssh-key options #4

Merged
merged 3 commits into from
Jul 23, 2023
Merged

Add hetznercloud network, firewall and ssh-key options #4

merged 3 commits into from
Jul 23, 2023

Conversation

xoxys
Copy link
Member

@xoxys xoxys commented Jul 18, 2023

  • add options for private/public networks and firewalls
  • use consistent lookup byName also for SSH keys
  • add support for multiple ssh keys

@xoxys
Copy link
Member Author

xoxys commented Jul 18, 2023

@6543 may I ask you again? Hope that pinging is ok.

anbraten
anbraten reviewed Jul 19, 2023
View reviewed changes
drivers/hetznercloud/flags.go Outdated Show resolved Hide resolved
drivers/hetznercloud/flags.go Outdated Show resolved Hide resolved
drivers/hetznercloud/flags.go Outdated Show resolved Hide resolved
drivers/hetznercloud/flags.go Outdated Show resolved Hide resolved
@anbraten anbraten changed the title Add hetznercloud network options Add hetznercloud network, firewall and ssh-key options Jul 19, 2023
@xoxys xoxys requested a review from anbraten July 19, 2023 06:49
@delete-merged-branch delete-merged-branch bot deleted the hcloud-network branch July 19, 2023 13:54
@xoxys xoxys restored the hcloud-network branch July 19, 2023 14:04
@anbraten anbraten merged commit 3761b20 into woodpecker-ci:main Jul 23, 2023
@anbraten anbraten mentioned this pull request Jul 23, 2023
Merged
@anbraten anbraten added the enhancement Enhance existing feature label Jul 27, 2023
@anbraten
Copy link
Member

🎉 This PR is included in version 0.1.0 🎉

The release is now available here

Thank you for your contribution. ❤️📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anbraten anbraten anbraten approved these changes

Assignees
No one assigned
Labels
enhancement Enhance existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xoxys @anbraten