Skip to content

Commit

Permalink
Fix: change tasks.task_data column type to longblob in mysql (#2418)
Browse files Browse the repository at this point in the history
Fix #2206 

Changes are copied and adapted from #1050
  • Loading branch information
s3lph authored Sep 10, 2023
1 parent ba71199 commit 47b9dab
Show file tree
Hide file tree
Showing 3 changed files with 39 additions and 1 deletion.
2 changes: 1 addition & 1 deletion server/model/task.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ type TaskStore interface {
// Task defines scheduled pipeline Task.
type Task struct {
ID string `json:"id" xorm:"PK UNIQUE 'task_id'"`
Data []byte `json:"data" xorm:"'task_data'"`
Data []byte `json:"data" xorm:"LONGBLOB 'task_data'"`
Labels map[string]string `json:"labels" xorm:"json 'task_labels'"`
Dependencies []string `json:"dependencies" xorm:"json 'task_dependencies'"`
RunOn []string `json:"run_on" xorm:"json 'task_run_on'"`
Expand Down
37 changes: 37 additions & 0 deletions server/store/datastore/migration/023_task_data_type.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
// Copyright 2023 Woodpecker Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package migration

import (
"xorm.io/xorm"
"xorm.io/xorm/schemas"
)

var alterTableTasksUpdateColumnTaskDataType = task{
name: "alter-table-tasks-update-type-of-task-data",
fn: func(sess *xorm.Session) (err error) {
dialect := sess.Engine().Dialect().URI().DBType

switch dialect {
case schemas.MYSQL:
_, err = sess.Exec("ALTER TABLE tasks MODIFY COLUMN task_data LONGBLOB")
default:
// xorm uses the same type for all blob sizes in sqlite and postgres
return nil
}

return err
},
}
1 change: 1 addition & 0 deletions server/store/datastore/migration/migration.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ var migrationTasks = []*task{
&parentStepsToWorkflows,
&addOrgs,
&addOrgID,
&alterTableTasksUpdateColumnTaskDataType,
}

var allBeans = []interface{}{
Expand Down

0 comments on commit 47b9dab

Please sign in to comment.