Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document GitHub app permissions #1081

Closed
3 tasks done
JulianGro opened this issue Aug 7, 2022 · 1 comment · Fixed by #2578
Closed
3 tasks done

Document GitHub app permissions #1081

JulianGro opened this issue Aug 7, 2022 · 1 comment · Fixed by #2578
Labels
documentation docu & docs forge/github github forge related good first issue Likely to be an easy fix

Comments

@JulianGro
Copy link
Contributor

Clear and concise description of the problem

Right now when adding WoodpeckerCI to GitHub you have to either give it full permission to do everything, or do trial and error.

Suggested solution

There should be a list of permissions WoodpeckerCI needs when used as a GitHub app.

Alternative

No response

Additional context

Most of the permissions I have enabled right now are just guesses.
The only permission I know for sure is needed is

User permissions:
	Email addresses: Read-only

Validations

@qwerty287 qwerty287 added documentation docu & docs forge/github github forge related and removed pending:feature labels Aug 7, 2022
@6543 6543 added this to the 1.0.0 milestone Sep 1, 2022
@6543
Copy link
Member

6543 commented Sep 1, 2022

oauth2 let's you declare the scope ... so it's not only documentation but also code we can improve

Scopes: []string{"repo", "repo:status", "user:email", "read:org"},

🤔 we already do this

@anbraten anbraten added the good first issue Likely to be an easy fix label Mar 20, 2023
@6543 6543 removed this from the 1.0.0 milestone May 30, 2023
@anbraten anbraten moved this to Backlog in next release Aug 30, 2023
qwerty287 pushed a commit that referenced this issue Oct 14, 2023
Add scopes needed when creating Github application.
Removed "repo:status" scope, because it is included in already requested
"repo" scope.

Fixes: #1081
@github-project-automation github-project-automation bot moved this from Backlog to Done in next release Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation docu & docs forge/github github forge related good first issue Likely to be an easy fix
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants