Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename procs and all other namings of it to steps #1288

Closed
Tracked by #869
anbraten opened this issue Oct 18, 2022 · 4 comments
Closed
Tracked by #869

Rename procs and all other namings of it to steps #1288

anbraten opened this issue Oct 18, 2022 · 4 comments
Labels
refactor delete or replace old code
Milestone
1.0.0

Comments

@anbraten
Copy link
Member

anbraten commented Oct 18, 2022 •
edited by 6543
Loading

ref #745
@6543 6543 added the refactor delete or replace old code label Oct 18, 2022
@6543 6543 added this to the 1.0.0 milestone Oct 18, 2022
@Harikesh00
Copy link
Contributor

Hi @anbraten, @6543
I wanna work on this
can u plz give me more insight into what are all changes required to do in this issue?
and how will I verify the changes I'll make are not breaking?

@6543
Copy link
Member

6543 commented Oct 24, 2022 •
edited
Loading

You could just start with renaming variables and code comments in code, that way nothing break and we have that already corrected ...

... rename structFields and tables are easy to get wrong and create regressions, but we can guide you through (that's what reviews are for)

@Harikesh00
Copy link
Contributor

ok, thanks @6543
I have started working on this
I'll raise a PR for review

@Harikesh00 Harikesh00 mentioned this issue Oct 24, 2022
Merged
6543 added a commit that referenced this issue Oct 28, 2022
@Harikesh00 @qwerty287 @6543
Renamed procs/jobs to steps in code (#1331)
36e4291 
Renamed `procs` to `steps` in code for the issue #1288

Co-authored-by: Harikesh Prajapati <harikesh.prajapati@druva.com>
Co-authored-by: qwerty287 <ndev@web.de>
Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
Co-authored-by: 6543 <6543@obermui.de>
@anbraten anbraten mentioned this issue Nov 26, 2022
Closed
31 tasks
@anbraten
Copy link
Member Author

is mostly done so closing this

simmstein pushed a commit to simmstein/woodpecker that referenced this issue Dec 27, 2022
@Harikesh00 @qwerty287
@6543 @simmstein
Renamed procs/jobs to steps in code (woodpecker-ci#1331)
13f1cdf 
Renamed `procs` to `steps` in code for the issue woodpecker-ci#1288

Co-authored-by: Harikesh Prajapati <harikesh.prajapati@druva.com>
Co-authored-by: qwerty287 <ndev@web.de>
Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
Co-authored-by: 6543 <6543@obermui.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor delete or replace old code
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@anbraten @6543 @Harikesh00