Show workflow state in UI

[anbraten]

We should show the state of a workflow similar to the state of a single step in front of the name.

In addition finished workflows (successful or failed) could be collapsed by default.

[dvjn]

There will be multiple steps in each workflow and they can have a mixture of states.
This opens up two options for the state indicator:

1. Combine the states into a single representative state with some logic like:
   • If any step is ['started', 'running'], then show blue
   • If any step is ['killed', 'error', 'failure', 'blocked', 'declined'], then show red
   • If all steps ['pending', 'skipped'], then show gray
   • Else show green
2. Get all the unique states (red, green, blue, gray) and show them in overlapping indicators
   

Thoughts @anbraten ?

[anbraten]

I would go for the first with a logic like:

• If any step is ['killed', 'error', 'failure', 'blocked', 'declined'], then show red
• If all steps passed, then show green
• If any step is ['started', 'running'], then show blue
• else use gray

[dvjn]

If all steps passed, then show green will not work since some steps may be skipped while other passed, which should show success.

How about this (my original logic with 1 and 2 swapped)?

• If any step is ['killed', 'error', 'failure', 'blocked', 'declined'], then show red
• If any step is ['started', 'running'] (inferred: no step has failed), then show blue
• If all steps ['pending', 'skipped'] (inferred: no step has failed or is running), then show gray
• Else (inferred: no step has failed or is running and not all are skipped/pending) show green

[anbraten]

Sounds fine.

[dvjn]

Sorry my bad, there was no need for this, each workflow already has a state value (which i can directly use).

Got confused by the name of the types in the code. A Pipeline contains PipelineSteps (i.e. Workflow) which contains again PipelineSteps (i.e. WorkflowStep)

[6543]

@dvjn are you sure you do target latest master branch, as this name-confusions should be mostly solved ...
#745

[6543]

If you still find relicts, just rename them while you catch them please :)

[lafriks]

If all steps passed, then show green will not work since some steps may be skipped while other passed, which should show success.

How about this (my original logic with 1 and 2 swapped)?

* If any step is ['killed', 'error', 'failure', 'blocked', 'declined'], then show red

* If any step is ['started', 'running'] (inferred: no step has failed), then show blue

* If all steps ['pending', 'skipped'] (inferred: no step has failed or is running), then show gray

* Else (inferred: no step has failed or is running and not all are skipped/pending) show green

Maybe last two steps could be changed:

• If any step is ['pending'] (inferred: no step has failed or is running), then show gray
• Else (inferred: no step has failed or is running or is pending) show green

This way if all steps are skipped would also mean that it is success as all is done, imho