Local backend fails when using clone configuration

[adamcstephens]

Component

server

Describe the bug

When using a local backend and specifying a clone configuration, the clone step fails.

This configuration:

clone:
  git:
    image: plugin-git
    settings:
      partial: false
      depth: 20

Generates this error:

Incorrect Usage. flag provided but not defined: -c

NAME:
   git plugin - git plugin
<SNIP>

Looking through the backend led me to try using the constant string.

woodpecker/pipeline/backend/local/local.go

Lines 131 to 139 in 0cf602a

	if step.Image == constant.DefaultCloneImage {
	// Default clone step
	// TODO: use tmp HOME and insert netrc and delete it after clone
	env = append(env, "CI_WORKSPACE="+state.workspaceDir)
	command = append(command, "plugin-git")
	} else {
	// Use "image name" as run command
	command = append(command, step.Image)
	command = append(command, "-c")

This does /not/ fail, but the settings are not honored nor supported.

clone:
  git:
    image: docker.io/woodpeckerci/plugin-git:2.0.3
    settings:
      partial: false

System Info

{"source":"https://github.com/woodpecker-ci/woodpecker","version":"next-3158980d"}

Additional context

No response

Validations

• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
• Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.

[adamcstephens]

SSH backend seems to have the same logic, and I suspect the same lack of support.

[6543]

With #1958 we dont need to guess if it's a clone step anymore ... the backend get's to know the types then too

[anbraten]

Was this solved by #2017?

[6543]

Uh most likely but i have to test

[6543]

yes it is ... but there looks to be a regression ... I'll close this and we can open a new issue if needed ...

[6543]

also "plugins" as in the example config will be supported by #2239

[adamcstephens]

Thanks! #2239 definitely looks like an improvement :)