Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let pipeline-compiler export step types #1958

Merged
merged 17 commits into from
Jul 11, 2023

Conversation

6543
Copy link
Member

@6543 6543 commented Jul 9, 2023

groundwork to address #269 (missing part are UI changes)

@6543 6543 added the server label Jul 9, 2023
@6543 6543 changed the title Let pipeline-compiler export step types and show in web ui Let pipeline-compiler export step types Jul 9, 2023
@6543 6543 marked this pull request as ready for review July 9, 2023 02:30
@6543 6543 added the enhancement improve existing features label Jul 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2023

Codecov Report

Patch coverage: 51.40% and project coverage change: -0.20 ⚠️

Comparison is base (6c58e9d) 39.28% compared to head (11bf6c1) 39.08%.

❗ Current head 11bf6c1 differs from pull request most recent head 92a8986. Consider uploading reports for the commit 92a8986 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1958      +/-   ##
==========================================
- Coverage   39.28%   39.08%   -0.20%     
==========================================
  Files         177      178       +1     
  Lines       10734    10786      +52     
==========================================
- Hits         4217     4216       -1     
- Misses       6223     6274      +51     
- Partials      294      296       +2     
Impacted Files Coverage Δ
pipeline/backend/docker/docker.go 0.00% <0.00%> (ø)
pipeline/backend/kubernetes/pod.go 0.00% <0.00%> (ø)
pipeline/frontend/yaml/compiler/convert.go 0.00% <0.00%> (ø)
pipeline/frontend/yaml/types/container.go 77.77% <0.00%> (ø)
server/model/pipeline.go 0.00% <ø> (ø)
server/model/step.go 0.00% <ø> (ø)
server/model/workflow.go 0.00% <ø> (ø)
...tastore/migration/020_parent_steps_to_workflows.go 59.45% <ø> (ø)
pipeline/frontend/yaml/compiler/compiler.go 6.93% <6.66%> (+0.11%) ⬆️
pipeline/stepBuilder.go 77.67% <67.85%> (+0.97%) ⬆️
... and 2 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

pipeline/frontend/yaml/compiler/convert.go Outdated Show resolved Hide resolved
server/model/step.go Show resolved Hide resolved
@6543 6543 requested a review from anbraten July 10, 2023 14:01
@6543 6543 requested a review from anbraten July 11, 2023 13:14
@6543 6543 added this to the 1.0.0 milestone Jul 11, 2023
@6543 6543 enabled auto-merge (squash) July 11, 2023 13:21
@6543 6543 merged commit b54f6eb into woodpecker-ci:master Jul 11, 2023
@6543 6543 deleted the frontend_step_types branch July 11, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants